CLOUDSTACK-9014 Rename xapi plugins for s3 and swift to make them work after renaming the calls - #982
Merged
Merged
Conversation
… the calls Renaming introduced in a8212d9 This PR is to address comments in PR apache#970
remibergsma
force-pushed
the
fix-s3-swift
branch
from
October 27, 2015 13:07
d51b4a3 to
5fed4f4
Compare
|
@remibergsma How did the tests work out? |
Contributor
Author
|
@xenserverarmy Sure, it works. It's very easy, the files end up in |
Contributor
Author
|
@DaanHoogland @wilderrodrigues You can do this to test this PR: Once the deploy is done:
Before this PR, the result was: Now it is: Can you also verify this please? |
Contributor
|
@remibergsma ... Will start testing now! Cheers, |
Contributor
|
Just tested it! LGTM 👍 I will also run some basic tests to make sure all is fine! Cheers, |
Member
|
manually tested by upgrading an existing xenserver setup and force reconnecting the host Before After I am guessing having the both the scripts after upgrade wont be an issue. I didnt see any issues after the change(manually tested launch new vm etc.) |
remibergsma
changed the title
Contributor
Author
|
@karuturi Added Jira issue CLOUDSTACK-9014 |
asfgit
pushed a commit
that referenced
this pull request
Oct 30, 2015
CLOUDSTACK-9014 Rename xapi plugins for s3 and swift to make them work after renaming the callsMake renaming introduced in a8212d9 work for S3 and Swift xapi plugins. This PR is to address comments in PR #970 * pr/982: Rename xapi plugins for s3 and swift to make them work after renaming the calls Signed-off-by: Remi Bergsma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make renaming introduced in a8212d9 work for S3 and Swift xapi plugins.
This PR is to address comments in PR #970