CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name by remibergsma · Pull Request #970 · apache/cloudstack

remibergsma · 2015-10-23T09:13:27Z

It's called s3xen, not s3xenserver. While investigating, I found the same issue for swiftxen.

Regresion from a8212d9 where things were massively renamed, without proper verification.

Error seen:

2015-10-22 21:42:30,372 WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-261:ctx-862ebceb) callHostPlugin failed for cmd: s3 with args maxErrorRetry: 10, secretKey: +XGy4yPPbAH9AijYxFTr1yVCCiVQuSfXWWj1Invs, 
connectionTtl: null, iSCSIFlag: false, maxSingleUploadSizeInBytes: 5368709120, bucket: mccx-nl2, endPoint: s3.storage.acc.schubergphilis.com, filename: /var/run/sr-mount/9414f970-0afd-42db-972f-aa4743293430/2
cf0c24b-a596-4039-b50a-7ce87da4f273.vhd, accessKey: 16efbc4e870f24338141, socketTimeout: null, https: false, connectionTimeout: 300000, operation: put, key: snapshots/2/10/2cf0c24b-a596-4039-b50a-7ce87da4f273
.vhd, useTCPKeepAlive: null,  due to Task failed! Task record:                 uuid: 4be8a515-1e2a-59de-6301-029fb0326651
           nameLabel: Async.host.call_plugin
     nameDescription: 
   allowedOperations: []
   currentOperations: {}
             created: Thu Oct 22 21:42:44 CEST 2015
            finished: Thu Oct 22 21:42:44 CEST 2015
              status: failure
          residentOn: com.xensource.xenapi.Host@9c7aad90
            progress: 1.0
                type: <none/>
              result: 
           errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []
Task failed! Task record:                 uuid: 4be8a515-1e2a-59de-6301-029fb0326651
           nameLabel: Async.host.call_plugin
     nameDescription: 
   allowedOperations: []
   currentOperations: {}
             created: Thu Oct 22 21:42:44 CEST 2015
            finished: Thu Oct 22 21:42:44 CEST 2015
              status: failure
          residentOn: com.xensource.xenapi.Host@9c7aad90
            progress: 1.0
                type: <none/>
              result: 
           errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
         otherConfig: {}
           subtaskOf: com.xensource.xenapi.Task@aaf13f6f
            subtasks: []

Here we see the correct name:

scripts/vm/hypervisor/xenserver/s3xen:lib.setup_logging("/var/log/cloud/s3xen.log")
scripts/vm/hypervisor/xenserver/xenserver56/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:s3xen=..,0755,/etc/xapi.d/plugins

And:

scripts/vm/hypervisor/xenserver/xenserver56/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:swiftxen=..,0755,/etc/xapi.d/plugins

These plugins are pushed to the hypervisor.

Finally, s3xen logrotate wasn't setup properly as the logfile was missing .log.

Build succeeds:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:27.763s
[INFO] Finished at: Fri Oct 23 09:08:14 GMT 2015
[INFO] Final Memory: 92M/415M
[INFO] ------------------------------------------------------------------------
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack Developer Mode 4.6.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------

After this, S3 works as expected on XenServer. Couldn't test swift but it's the same issue. Pinging @pdion891 to have look at swift.

It's called s3xen, not s3xenserver Regresion from a8212d9

It's called swiftxen, not swiftxenserver Regresion from a8212d9

Apart from s3xen / s3xenserver it missed .log so it never worked.

remibergsma · 2015-10-23T09:25:02Z

Verified this is also broken in 4.5 btw.

DaanHoogland · 2015-10-23T09:41:44Z

makes sense. just code reviewed. will review the breaking commit to see if I can spot other superfluent changes in there as well.

borisroman · 2015-10-23T18:52:48Z

Based on code review, LGTM 👍

I haven't spun up a cluster to run integration tests...

remibergsma · 2015-10-23T19:00:02Z

@borisroman Thanks, will ask @wilderrodrigues to run some integration tests.

borisroman · 2015-10-23T19:01:02Z

@remibergsma @wilderrodrigues Thanks!

wilderrodrigues · 2015-10-26T09:43:58Z

@remibergsma @borisroman - I'm starting tests now.

wilderrodrigues · 2015-10-26T09:48:44Z

Code look good to me, no rocket science involved.

I will test it with XenServer 6.5, but I might need help figuring out how to get it covered.

Cheers,
Wilder

koushik-das · 2015-10-26T10:18:01Z

Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in scripts/vm/hypervisor/xenserver/?

koushik-das · 2015-10-26T10:26:01Z

Ping @Runseb.
Is there a handle/userid for Tim Mackey?

wilderrodrigues · 2015-10-26T11:19:59Z

Good point, @koushik-das.

@remibergsma: do you agree on that one as well?

xenserverarmy · 2015-10-26T14:33:12Z

@koushik-das One of the goals of a8212d9 was to ensure that we have clarity in which hypervisor we support since Xen != XenServer. Reverting based on name IMO might be the simple solution, but could ultimately cause additional confusion as we don't currently have a pure Xen hypervisor implementation.

@wilderrodrigues @remibergsma, I didn't have s3 or swift storage to test with at the time of my changes. Would not the better solution be to rename the plugin s3xenserver and swiftxenserver?

remibergsma · 2015-10-26T15:56:20Z

I will test if renaming the plugin works (and make sure there are no links to its name).

… the calls Renaming introduced in a8212d9 This PR is to address comments in PR apache#970

remibergsma · 2015-10-26T16:49:14Z

New PR #982

… the calls Renaming introduced in a8212d9 This PR is to address comments in PR apache#970

CLOUDSTACK-9014 Rename xapi plugins for s3 and swift to make them work after renaming the callsMake renaming introduced in a8212d9 work for S3 and Swift xapi plugins. This PR is to address comments in PR #970 * pr/982: Rename xapi plugins for s3 and swift to make them work after renaming the calls Signed-off-by: Remi Bergsma <[email protected]>

remibergsma added 3 commits October 23, 2015 10:01

CLOUDSTACK-8987 call s3xen plugin with its name

4bf1b01

It's called s3xen, not s3xenserver Regresion from a8212d9

CLOUDSTACK-8987 call swiftxen plugin with its name

2bf9f28

It's called swiftxen, not swiftxenserver Regresion from a8212d9

CLOUDSTACK-8987 s3xen uses s3xen.log

0e7abe4

Apart from s3xen / s3xenserver it missed .log so it never worked.

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Oct 26, 2015

Rename xapi plugins for s3 and swift to make them work after renaming…

d51b4a3

… the calls Renaming introduced in a8212d9 This PR is to address comments in PR apache#970

remibergsma mentioned this pull request Oct 26, 2015

CLOUDSTACK-9014 Rename xapi plugins for s3 and swift to make them work after renaming the calls #982

Merged

remibergsma closed this Oct 26, 2015

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Oct 27, 2015

Rename xapi plugins for s3 and swift to make them work after renaming…

5fed4f4

… the calls Renaming introduced in a8212d9 This PR is to address comments in PR apache#970

Navigation Menu

Uh oh!

CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name - #970

CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name#970
remibergsma wants to merge 3 commits into
apache:masterfrom
remibergsma:s3xen-fix

remibergsma commented Oct 23, 2015

Uh oh!

remibergsma commented Oct 23, 2015

Uh oh!

DaanHoogland commented Oct 23, 2015

Uh oh!

borisroman commented Oct 23, 2015

Uh oh!

remibergsma commented Oct 23, 2015

Uh oh!

borisroman commented Oct 23, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

koushik-das commented Oct 26, 2015

Uh oh!

koushik-das commented Oct 26, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

xenserverarmy commented Oct 26, 2015

Uh oh!

remibergsma commented Oct 26, 2015

Uh oh!

remibergsma commented Oct 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

remibergsma commented Oct 23, 2015

Uh oh!

remibergsma commented Oct 23, 2015

Uh oh!

DaanHoogland commented Oct 23, 2015

Uh oh!

borisroman commented Oct 23, 2015

Uh oh!

remibergsma commented Oct 23, 2015

Uh oh!

borisroman commented Oct 23, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

koushik-das commented Oct 26, 2015

Uh oh!

koushik-das commented Oct 26, 2015

Uh oh!

wilderrodrigues commented Oct 26, 2015

Uh oh!

xenserverarmy commented Oct 26, 2015

Uh oh!

remibergsma commented Oct 26, 2015

Uh oh!

remibergsma commented Oct 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants