CLOUDSTACK-8852 Database shows that management server is UP when it i… - #840
Merged
Conversation
|
cloudstack-pull-rats #627 SUCCESS |
bvbharatk
force-pushed
the
CLOUDSTACK-8852
branch
from
September 16, 2015 08:56
17a5d29 to
4826e22
Compare
|
cloudstack-pull-rats #628 SUCCESS |
|
cloudstack-pull-analysis #566 FAILURE |
|
cloudstack-pull-analysis #567 ABORTED |
|
cloudstack-pull-analysis #587 SUCCESS |
Member
|
LGTM, pl fix one of the indentation issues and perhaps use better and verbose log messages. |
…s actually stopped from the CCP GUI
This was happening as the stop method in clusterMnanagerImpl was not getting callled. Added shutdown hooks to all sub contexts,
this enables spring to call the stop mehtods of the beans when management server is shutting down.
Conflicts:
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java
bvbharatk
force-pushed
the
CLOUDSTACK-8852
branch
from
November 2, 2015 09:57
4826e22 to
4849368
Compare
Contributor
Author
|
fixed the double indent. |
Contributor
|
LGTM based on these tests: Result: And: Result: I didn't test the actual feature. This just shows it didn't break anything else. |
asfgit
pushed a commit
that referenced
this pull request
Dec 5, 2015
CLOUDSTACK-8852 Database shows that management server is UP when it iDatabase shows that management server is UP when it is actually stopped. This was happening as the stop method in clusterMnanagerImpl was not getting callled. Added shutdown hooks to all spring sub contexts, this enables spring to call the stop mehtods of the beans when management server is shutting down. Conflicts: framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java * pr/840: CLOUDSTACK-8852 Database shows that management server is UP when it is actually stopped from the CCP GUI Signed-off-by: Remi Bergsma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database shows that management server is UP when it is actually stopped.
This was happening as the stop method in clusterMnanagerImpl was not getting callled. Added shutdown hooks to all spring sub contexts, this enables spring to call the stop mehtods of the beans when management server is shutting down.
Conflicts:
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java