Quota master - #689
Conversation
|
cloudstack-pull-rats #281 SUCCESS |
|
cloudstack-pull-requests #978 SUCCESS |
|
cloudstack-pull-analysis #214 SUCCESS |
|
one big chunk of work Abhi, I have skimmed it and the structure looks good. I must have missed some minor issues in these 7000+ lines of code, though. |
|
@DaanHoogland I think the aim here is to bring the work out for everyone to review early on, Abhi tells me he's already working on unit and marvin tests. |
|
@bhaisaab well it looks promising. |
|
cloudstack-pull-rats #318 FAILURE |
|
cloudstack-pull-requests #1014 FAILURE |
|
cloudstack-pull-rats #321 ABORTED |
|
cloudstack-pull-requests #1017 ABORTED |
|
cloudstack-pull-analysis #250 FAILURE |
|
cloudstack-pull-analysis #253 ABORTED |
|
@DaanHoogland @kishankavala @jburwell The documentation to run and check the plugin are in this pull request: apache/cloudstack-docs-admin#30 |
There was a problem hiding this comment.
Debug logging statements should be wrapped in a if (s_logger.isDebugEnabled()) check to avoid the overhead of string concatenation when debug logging is not enabled.
There was a problem hiding this comment.
Accepted.
There was a problem hiding this comment.
Please remove commented code as it builds up cruft.
|
The Transaction open and close causing churn in database connection is based on the notion that these methods somehow open and close db connections. |
|
cloudstack-pull-rats #416 SUCCESS |
|
cloudstack-pull-analysis #349 SUCCESS |
|
cloudstack-pull-rats #424 SUCCESS |
|
cloudstack-pull-analysis #357 ABORTED |
Quota service while allowing for scalability will make sure that the cloud is not exploited by attacks, careless use and program errors. To address this problem, we propose to employ a quota-enforcement service that allows resource usage within certain bounds as defined by policies and available quotas for various entities. Quota service extends the functionality of usage server to provide a measurement for the resources used by the accounts and domains using a common unit referred to as cloud currency in this document. It can be configured to ensure that your usage won’t exceed the budget allocated to accounts/domain in cloud currency. It will let user know how much of the cloud resources he is using. It will help the cloud admins, if they want, to ensure that a user does not go beyond his allocated quota. Per usage cycle if a account is found to be exceeding its quota then it is locked. Locking an account means that it will not be able to initiat e a new resource allocation request, whether it is more storage or an additional ip. Needless to say quota service as well as any action on the account is configurable. FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Quota+Service+-+FS Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
- added marvin test for quota plugin API - removed unused commented code - debug messages in debug enabled check - checks for nulls, fixed access to member variables and feature - changes based on PR comments
|
Changes included from the PR, branch rebased from latest master. Please help review - @karuturi @jburwell @DaanHoogland @remibergsma @kishankavala and others |
|
cloudstack-pull-rats #452 SUCCESS |
|
I will re-review later today (31 August 2015). |
|
@bhaisaab lot of code :) .. I will review tomorrow. |
|
7.5kloc would justify 15klotc (kilo-lines of test code) I am not very worried about the quality of this code or the zeal of some bluely shaped programmers to maintain it but it will have to be maintainable by others! over 10 lines of code is an hazard to review if there is not twice as much test-code there, give or take. |
|
cloudstack-pull-analysis #385 ABORTED |
|
New PR here: #768 |
6 participants
This pull request is for quota service implementation, divided into following two commits:
a. Quota Framework plugin containing Daos
b. Quota database plugin for quota APIs
c. Quota Usage server enhancements