ui: Refresh Usage dashboard when swapping between Project and Default view - #5447
Merged
Conversation
Contributor
Author
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
Author
@rhtyd There isn't an id (project ID) for default view - which was the reason for not refreshing in the earlier case. |
Member
|
Ah okay that makes sense, maybe we can add a dummy ID of 0 for default view? But this change also LGTM if it works. |
shwstppr
reviewed
Sep 14, 2021
| (state, getters) => getters.project, | ||
| (newValue, oldValue) => { | ||
| if (newValue && newValue.id) { | ||
| if (newValue && newValue !== oldValue) { |
Contributor
There was a problem hiding this comment.
@Pearl1594 why not compare ids itself? This condition might be as good as if (newValue) {
Contributor
Author
There was a problem hiding this comment.
there is no id for default view @shwstppr
utchoang
approved these changes
Sep 15, 2021
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5440 - where we notice that when logged in with a User role, and on swapping between project and default view, the resource count details on the Usage dashboard isn't properly updated
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Followed the steps mentioned in #5440 - and observed the usage dashboard properly updated.