UI: Support to upload resource icons by Pearl1594 · Pull Request #5157 · apache/cloudstack

Pearl1594 · 2021-06-25T03:45:52Z

Description

This PR provides support for adding resource icons/ images for Zones, templates, ISOs, UserVMs, Networks, VPCs, Domains, Projects, Accounts and users which will helps users/admins in future to identify special-purpose templates and VMs using custom icons in UI. Some of the attributes of this feature includes:

Users will inherit the account's icon if not present.
Isolated networks tiers of a VPC network will inherit the Icon of the VPC network if present.
Resources that support uploading custom icons have a small symbol against the logo.
Users with permission to access resources can upload/update and delete the icons. If no icons have been provided, it follows the normal behavior. Info Card view will also display the corresponding resource's icons if present.
The Deploy VM wizard will show the list of zones in the form of cards in the number of zones are <= 8

Else, it defaults to the usual list view but will display the icon beside the zone name
The capacity dashboard view will also display the zone icons beside the zone names as shown above
The project list view (Used for switching to different projects available, on the Dashboard page) will also list the project icons beside the project names
List view of all resources that support resource icons will now display the icons beside the name
The user/account icon will be displayed at the top right corner of the landing / dashboard page

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

…resource-icon

Pearl1594 · 2021-06-25T05:41:31Z

@blueorangutan package

blueorangutan · 2021-06-25T05:42:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-06-25T06:24:06Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 364

DaanHoogland · 2021-06-25T10:50:02Z

\o/

Pearl1594 · 2021-06-28T09:06:38Z

@blueorangutan package

blueorangutan · 2021-06-28T09:07:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-06-28T09:32:28Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 390

Pearl1594 · 2021-06-28T09:38:21Z

@blueorangutan test

blueorangutan · 2021-06-28T09:39:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-06-28T21:10:35Z

Trillian test result (tid-1131)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39755 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1131-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_and_upgrade_kubernetes_cluster	`Failure`	443.47	test_kubernetes_clusters.py

Pearl1594 · 2021-06-29T13:05:39Z

@blueorangutan package

blueorangutan · 2021-06-29T13:06:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-06-29T13:46:06Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 423

Pearl1594 · 2021-06-29T13:56:07Z

@blueorangutan test

blueorangutan · 2021-06-29T13:57:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-06-30T06:25:34Z

Trillian test result (tid-1158)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1158-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_lb_rule_src_nat	`Failure`	617.96	test_loadbalance.py
test_02_create_lb_rule_non_nat	`Failure`	77.50	test_loadbalance.py
test_assign_and_removal_lb	`Failure`	75.30	test_loadbalance.py
test_01_add_primary_storage_disabled_host	`Error`	0.55	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.16	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.23	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.16	test_snapshots.py
test_01_secure_vm_migration	`Error`	148.71	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	266.16	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	140.58	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	43.70	test_vm_life_cycle.py
test_hostha_kvm_host_fencing	`Error`	712.36	test_hostha_kvm.py

resource icon support for vpcs, networks, domains, and projects add icons to list view if reosurces support icons to be added support for showing project icons in the project switching drop-down menu

Pearl1594 · 2021-07-01T10:01:46Z

@blueorangutan package

blueorangutan · 2021-07-01T10:02:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Pearl1594 · 2021-09-08T07:59:33Z

@blueorangutan package

blueorangutan · 2021-09-08T08:00:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-08T08:32:58Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1174

Pearl1594 · 2021-09-08T08:55:24Z

@blueorangutan test

blueorangutan · 2021-09-08T08:57:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-08T19:02:33Z

Trillian test result (tid-1991)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1991-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2021-09-08T19:03:02Z

Trillian test result (tid-1990)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1990-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

…resource-icon

Pearl1594 · 2021-09-09T12:37:23Z

@blueorangutan package

blueorangutan · 2021-09-09T12:38:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-09T13:02:58Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1196

…resource-icon

Pearl1594 · 2021-09-14T04:52:03Z

@blueorangutan package

blueorangutan · 2021-09-14T04:54:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-14T05:57:23Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1228

blueorangutan · 2021-09-14T05:57:23Z

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1227

Pearl1594 · 2021-09-14T06:01:13Z

@blueorangutan package

blueorangutan · 2021-09-14T06:02:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-14T07:12:39Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1232

Pearl1594 · 2021-09-14T07:22:03Z

@blueorangutan test

blueorangutan · 2021-09-14T07:23:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-09-14T08:57:42Z

LGTM - this has passed manual and smoketests + 2xLGTMs; can be merged after the final smoketests run.

blueorangutan · 2021-09-14T18:02:36Z

Trillian test result (tid-2035)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36515 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t2035-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

LGTM

yadvr · 2021-09-15T09:22:07Z

Nice!

Pearl1594 added 6 commits June 14, 2021 21:24

Resource Icon support - backend

c9bdac4

Add API support for resourceicon

fd9502a

update reponse params + ui support

fcd5eb6

Merge branch 'main' of https://github.com/apache/cloudstack into add-…

af7b969

…resource-icon

Add exclusive list api for icons and UI changes

25d5272

Merge branch 'main' of https://github.com/apache/cloudstack into add-…

2e30bfd

…resource-icon

refactor upload view

23d5bdb

UI changes to support resource icon wherever necessary

1378cc7

convert api to POST + refactor icon view

96beb7b

yadvr added the component:UI label Jun 29, 2021

Add response name to list API + cosmetic changes in UI

8a69934

Added support for the following:

301310c

resource icon support for vpcs, networks, domains, and projects add icons to list view if reosurces support icons to be added support for showing project icons in the project switching drop-down menu

shwstppr approved these changes Sep 8, 2021

View reviewed changes

Merge branch 'main' of https://github.com/apache/cloudstack into add-…

d0ba725

…resource-icon

Pearl1594 marked this pull request as ready for review September 9, 2021 12:35

Merge branch 'main' of https://github.com/apache/cloudstack into add-…

7d1686f

…resource-icon

yadvr approved these changes Sep 14, 2021

View reviewed changes

nvazquez approved these changes Sep 15, 2021

View reviewed changes

nvazquez merged commit 3f827ef into apache:main Sep 15, 2021

nvazquez added the type:new-feature label Oct 14, 2021

Uh oh!

Conversation

Pearl1594 commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Pearl1594 commented Jun 25, 2021

Uh oh!

blueorangutan commented Jun 25, 2021

Uh oh!

blueorangutan commented Jun 25, 2021

Uh oh!

DaanHoogland commented Jun 25, 2021

Uh oh!

Pearl1594 commented Jun 28, 2021

Uh oh!

blueorangutan commented Jun 28, 2021

Uh oh!

blueorangutan commented Jun 28, 2021

Uh oh!

Pearl1594 commented Jun 28, 2021

Uh oh!

blueorangutan commented Jun 28, 2021

Uh oh!

blueorangutan commented Jun 28, 2021

Uh oh!

Pearl1594 commented Jun 29, 2021

Uh oh!

blueorangutan commented Jun 29, 2021

Uh oh!

blueorangutan commented Jun 29, 2021

Uh oh!

Pearl1594 commented Jun 29, 2021

Uh oh!

blueorangutan commented Jun 29, 2021

Uh oh!

blueorangutan commented Jun 30, 2021

Uh oh!

Pearl1594 commented Jul 1, 2021

Uh oh!

blueorangutan commented Jul 1, 2021

Uh oh!

Pearl1594 commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

Pearl1594 commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

blueorangutan commented Sep 8, 2021

Uh oh!

Pearl1594 commented Sep 9, 2021

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

blueorangutan commented Sep 9, 2021

Uh oh!

Pearl1594 commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

Pearl1594 commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Pearl1594 commented Jun 25, 2021 •

edited

Loading