Skip to content

Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG - #4130

Merged
yadvr merged 1 commit into
apache:4.13from
shapeblue:null-pointer-on-migrate-after-snapshot-remove
Jun 15, 2020
Merged

Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG#4130
yadvr merged 1 commit into
apache:4.13from
shapeblue:null-pointer-on-migrate-after-snapshot-remove

Conversation

@Spaceman1984

@Spaceman1984 Spaceman1984 commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Description

Fixes #4090

When trying to migrate a VM across 2 clusters, if a snapshot has been deleted and garbage collection has run to update the removed field, it is not possible to migrate the instance due to a null pointer.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This has been tested by migrating an instance to another Xenserver cluster using XCP-NG as the hypervisor in both clusters.

Process to follow:

  • Create a zone with 2 clusters.
  • Create an instance in 1 cluster.
  • Take a root volume snapshot of the instance.
  • Delete the snapshot.
  • Wait for the removed field to be populated in the snapshots table.
  • Migrate the instance.

@yadvr yadvr added this to the 4.13.2.0 milestone Jun 8, 2020
@yadvr

yadvr commented Jun 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@Spaceman1984 could you run package and test yourself for your PRs in future?
@blueorangutan package

@blueorangutan

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1299

@yadvr

yadvr commented Jun 9, 2020

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 9, 2020

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Jun 13, 2020
@yadvr

yadvr commented Jun 13, 2020

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Jun 13, 2020

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jun 13, 2020

Copy link
Copy Markdown

Trillian test result (tid-1701)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32371 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4130-t1701-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 184.32 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 182.01 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 250.19 test_privategw_acl.py

shwstppr
shwstppr approved these changes Jun 15, 2020
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense for preventing NPE

@yadvr
yadvr merged commit 6a683dc into apache:4.13 Jun 15, 2020
@sureshanaparti sureshanaparti mentioned this pull request Apr 15, 2021
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@shwstppr shwstppr shwstppr approved these changes
@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland
@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

Severity:Minor type:bug

Projects

None yet

Milestone

4.13.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Spaceman1984 @yadvr @blueorangutan @shwstppr @DaanHoogland