Skip to content

return stored value for secure configs so listConfigurations stays the same - #14309

Open
Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:nl/issue-14306
Open

return stored value for secure configs so listConfigurations stays the same#14309
Damans227 wants to merge 1 commit into
apache:mainfrom
Damans227:nl/issue-14306

Conversation

@Damans227

@Damans227 Damans227 commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes #14306

Listing configurations in the Secure category gives a different value every time, even when nothing changed. The value is stored encrypted, but the list call decrypted it and encrypted it again, and each new encryption comes out different. This returns the encrypted value as it is stored, so the output stays the same until the setting actually changes.

Test:

Run list configurations category=Secure twice in a row with cmk and compare the values. Values below are cut to the first 24 characters.

Before: every set value changes between the two calls.

# first call
backup.plugin.networker.password ZddciElO1udo3Pl+agXrHARG
network.loadbalancer.haproxy.stats.auth f51/g2uRBsvefBJsaoHUQ4lP
security.singlesignon.key lQ03Tqq8CIau7LIDDf5XCWr7
# second call
backup.plugin.networker.password XnKELrtDmHe6f9BRaBoXyHFp
network.loadbalancer.haproxy.stats.auth jplo4cvuOJZVipmyz/8/IcIH
security.singlesignon.key ut3RFlVXAKkqC88lnOiO/IIC

After: both calls return the same values, and they match the configuration table.

# first and second call
backup.plugin.networker.password KZdkoJLySbJ1j5C/YE5olDKM
network.loadbalancer.haproxy.stats.auth YU9iU0+6TfvwjkCH2225y8n7
security.singlesignon.key JibDMnWzxEEnvyBIvIMrtvRx
# select name, left(value,24) from configuration where category='Secure'
backup.plugin.networker.password	KZdkoJLySbJ1j5C/YE5olDKM
network.loadbalancer.haproxy.stats.auth	YU9iU0+6TfvwjkCH2225y8n7
security.singlesignon.key	JibDMnWzxEEnvyBIvIMrtvRx

@Damans227

Damans227 commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 5, 2026

Copy link
Copy Markdown

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.92%. Comparing base (1a48a87) to head (2554589).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...udstack/framework/config/impl/ConfigurationVO.java 33.33% 2 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14309      +/-   ##
============================================
+ Coverage     19.91%   19.92%   +0.01%     
- Complexity    20199    20204       +5     
============================================
  Files          6373     6373              
  Lines        577230   577235       +5     
  Branches      70696    70697       +1     
============================================
+ Hits         114950   115011      +61     
+ Misses       449713   449653      -60     
- Partials      12567    12571       +4
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 21.19% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

blueorangutan commented Oct 5, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19409

@Damans227
Damans227 marked this pull request as ready for review October 5, 2026 15:20
weizhouapache
weizhouapache approved these changes Oct 5, 2026
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

thanks @Damans227 !

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

listConfigurations API returns different value of "Secure" configurations even value is not changed

3 participants

@Damans227 @blueorangutan @weizhouapache