Removal of DefaultUserAuthenticator empty class. - #1100
Merged
asfgit merged 1 commit intoNov 29, 2015
Conversation
Contributor
|
@alexandrelimassantana Did you check who created the DefaultUserAuthenticator? Your change makes sense to me but I would like to know why it was created before deleting it. code lgtm, btw. |
Member
|
Hi @DaanHoogland, |
Contributor
|
ah @rafaelweingartner you did the check for @alexandrelimassantana , ok ;) |
Member
|
Sure ;) |
Contributor
Author
|
Thanks for that look-up @rafaelweingartner. Yeah that class was very old, 2015-11-21 20:52 GMT-02:00 Rafael Weingärtner [email protected]:
|
Member
|
LGTM |
Contributor
|
@alexandrelimassantana Can you rebase please and resolve the conflict? Thanks! |
The DefaultUserAuthenticator is an empty class, extending the AdapterBase and implementing the UserAuthenticator interface. The class is only being used as a marker and it's sole use is to be extended by other UserAuthenticators. Noticing that the class had no purpose, I removed it and made it's children extend from it's superclass and implement it's interface instead. Also, I removed the @Local tags from those classes, since EJB is not used anymore.
rafaelweingartner
force-pushed
the
master-lrg-cs-hackday-005
branch
from
November 27, 2015 23:30
cd57451 to
98594b7
Compare
Member
|
@remibergsma I have rebase the PR and resolved the conflicts for @alexandrelimassantana |
Contributor
|
LGTM based on the tests below. Can't really judge the change itself. Result: And: Result: |
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2015
…-005 Removal of DefaultUserAuthenticator empty class.The DefaultUserAuthenticator is an empty class, extending from the AdapterBase and implementing the UserAuthenticator interface. The class is not being used as a marker and it's sole use is to be extended by other UserAuthenticators. Noticing that the class had no purpose, I removed it and made it's children extend from it's superclass and implement it's interface instead. Also, I removed the @Local tags from those classes, since EJB is not used anymore. * pr/1100: Removal of DefaultUserAuthenticator empty class Signed-off-by: Remi Bergsma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DefaultUserAuthenticator is an empty class, extending from the
AdapterBase and implementing the UserAuthenticator interface. The class
is not being used as a marker and it's sole use is to be extended by
other UserAuthenticators. Noticing that the class had no purpose, I
removed it and made it's children extend from it's superclass and
implement it's interface instead. Also, I removed the @Local tags from
those classes, since EJB is not used anymore.