[4.7] CLOUDSTACK-8958: add dedicated ips to domain (account for now) - #1007
Merged
Conversation
ustcweizhou
force-pushed
the
dedicated-ip-for-domain
branch
from
October 29, 2015 20:37
cf39ff3 to
67e6956
Compare
Contributor
|
LGTM, based on a set of tests that I run on this branch (which I rebased myself first): Result: And: Result: These test do not cover your change, all they do is show you didn't break them. Someone else needs to review the code. |
Contributor
|
FYI: Running tests on this now |
Contributor
|
@remibergsma LGMT 👍 Reviewed the code and run the vm_lifecycle_test. |
Contributor
There was a problem hiding this comment.
vlanOwner check is now done only when account is specified. What about the project case which also can set the vlanOwner?
Contributor
There was a problem hiding this comment.
@ustcweizhou This PR is almost ready to be merged. Please respond to comments above.
Contributor
Author
There was a problem hiding this comment.
@remibergsma I added a second commit to fix it. However, it did not touch these codes, but code before these.
Contributor
There was a problem hiding this comment.
@koushik-das You OK with the PR like it is now? Please review again, thanks!
Contributor
There was a problem hiding this comment.
Looks like the project case is handled by 89ce8bd. Since all tests pass, I will merge this now. Future adjustments can be made in a separate PR.
Member
|
LGTM |
ustcweizhou
changed the title
ustcweizhou
force-pushed
the
dedicated-ip-for-domain
branch
from
November 16, 2015 09:19
e53ab9e to
89ce8bd
Compare
Contributor
|
Repeated the tests due to new commits: LGTM based on these tests: Result: And: Result: |
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2015
[4.7] CLOUDSTACK-8958: add dedicated ips to domain (account for now)For now, we dedicate ip pool to account, however, other accounts in the same domain cannot fetch the ip from this ip pool. By dedicating ip pool to domain, accounts in the domain can fetch the public ip from same ip pool. * pr/1007: CLOUDSTACK-8958: throw an exception if project account cannot be found CLOUDSTACK-8958: add dedicated ips to domain (account for now) Signed-off-by: Remi Bergsma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, we dedicate ip pool to account, however, other accounts in the same domain cannot fetch the ip from this ip pool.
By dedicating ip pool to domain, accounts in the domain can fetch the public ip from same ip pool.