"Add VPC" Button does nothing if no Advanced Zone with securitygroupsenabled=false #2698

ISSUE TYPE

• Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.11.1.0-rc1

From: http://packages.shapeblue.com/testing/4111rc1/centos7/4.11/
But should be the same in previous versions (like 4.11)

CONFIGURATION

Zone 1 = Basic
Zone 2 = Advanced + securitygroupsenabled = true

OS / ENVIRONMENT

N/A

SUMMARY

CloudStack UI --> Network --> Switch View to VPC
Click Button "Add VPC"

Problem: nothing happens
Tested in browsers: FireFox, Edge

Error happens here: TypeError: advZones[0] is undefined
https://github.com/apache/cloudstack/blob/master/ui/scripts/network.js#L5202
(https://github.com/apache/cloudstack/blob/4.11/ui/scripts/network.js#L5202)

Cause:

When there is no Zone with networktype Advanced + securitygroupsenabled = false
https://github.com/apache/cloudstack/blob/master/ui/scripts/network.js#L5163

STEPS TO REPRODUCE

Have no advanced Zone with securitygroupsenabled = no

CloudStack UI --> Network --> Switch View to VPC
Click Button "Add VPC"

EXPECTED RESULTS

Expected: error that there is no compatiple Zone + requirements that are needed

ACTUAL RESULTS

nothing happens visually (JavaScript error)

TypeError: advZones[0] is undefined