Support distributed by clause specification when Create MV if not exists#563
Merged
Conversation
Contributor
Author
|
hmmm icw-test are failing, but they look unrelated to C.M.V, aren't they? |
Contributor
|
Hi, please provide cases to verify what you have done. |
Contributor
Author
Hi, you mean some regression test-cases? They are as obvious as (this fails on current HEAD) I dont think we need anything more complicated here. Will do |
Contributor
Author
|
Seems that matview_optimizer.out depends on matview tests. Pushed commit should fix test |
avamingli
reviewed
Aug 9, 2024
reshke
commented
Aug 9, 2024
Contributor
Author
|
Are there any open items/suggestion/issues? |
avamingli
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$subj
For some reason, current grammatical parser does not accept Distributed By clause in case IF NOT EXISTS specified for materialized view, which I don't any any reason to disallow