Skip to content

Fix the correct size of memory block in bitmapinsert#495

Merged
gfphoenix78 merged 1 commit into
apache:mainfrom
gfphoenix78:fix-memset
Jul 8, 2024
Merged

Fix the correct size of memory block in bitmapinsert#495
gfphoenix78 merged 1 commit into
apache:mainfrom
gfphoenix78:fix-memset

Conversation

@gfphoenix78

Copy link
Copy Markdown
Contributor

The field hwords of BMTIDBuffer is a fixed array, not variable.


How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@avamingli avamingli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The field `hwords` of BMTIDBuffer is a fixed array, not variable.
@gfphoenix78
gfphoenix78 merged commit d68aede into apache:main Jul 8, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
The field `hwords` of BMTIDBuffer is a fixed array, not variable.

(cherry picked from commit d68aede)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants