Skip to content

Update geomet to latest in requirements.txt#1207

Merged
absurdfarce merged 1 commit intoapache:masterfrom
bschoening:patch-4
May 31, 2024
Merged

Update geomet to latest in requirements.txt#1207
absurdfarce merged 1 commit intoapache:masterfrom
bschoening:patch-4

Conversation

@bschoening
Copy link
Copy Markdown
Contributor

@bschoening bschoening commented May 7, 2024

Geomet 0.3 only officially supports EOL Python versions 2.7 ... 3.7 and has an unnecessary dependency on the python 2 compatibility library 'six'. Upgrading to 1.1.0 resolves this.

This a blocking issue for a Homebrew PR to remove six from the Cassandra package

@bschoening bschoening changed the title Update gemet to latest in requirements.txt Update geomet to latest in requirements.txt May 7, 2024
@absurdfarce
Copy link
Copy Markdown
Contributor

Triggered a PR build for this, just to make sure there aren't any obvious regressions with the unit/integration tests

@bschoening
Copy link
Copy Markdown
Contributor Author

@absurdfarce I'm unable to see the pr-merge output which is on dsinternal.org, but can you share what failed?

@absurdfarce
Copy link
Copy Markdown
Contributor

Hey @bschoening, thanks for following up! The failures for that run are all known intermittent test failures that creep up from time to time. I've tried to fix a few of the more obvious ones but my expectation is that most (maybe all?) will go away once we finish the move to pytest.

The one thing I do still need to check here is how this behaves with tests.unit.advanced.test_geometry; that test wasn't run for the test configuration powering that Jenkins run. If that test is good I think I'm satisfied there's no API change in this version of geomet. Worth noting that the test_geometry unit test does employ a skipUnless annotation to skip several test cases if geomet isn't installed.

@absurdfarce
Copy link
Copy Markdown
Contributor

A quick update: tests.unit.advanced.test_geometry passes locally for me with geomet 1.1 in play.

@absurdfarce
Copy link
Copy Markdown
Contributor

I also re-ran tests.integration.advanced.test_geometry against DSE 6.8.30 locally and observed results similar to those reported by Jenkins (i.e. all passed except for two methods on BasicGeometricPointTypeTest which both have unittest.skip annotations in place). At this point I don't have any reason to believe there's a problem with the upgrade here so I'm calling this good.

@absurdfarce absurdfarce merged commit 90c71ad into apache:master May 31, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Mar 5, 2025
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Mar 5, 2025
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Mar 5, 2025
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Mar 5, 2025
dkropachev pushed a commit to scylladb/python-driver that referenced this pull request Mar 5, 2025
@hwlodarczyk-rtbh
Copy link
Copy Markdown
Contributor

Hello.
Why have you updated geomet version only in requirements.txt file where in setup.py old reqmirement is still present https://github.com/datastax/python-driver/blob/1798cf7464e53e01abf7f4c820b60d75beac37da/setup.py#L386 ?
I've tried to update packages using poetry and it downgraded cassandra-driver version to 3.20.2 from 3.29.1 because it doesn't have any geomet requirements and I have to use geomet==1.1.0 in project.

@bschoening
Copy link
Copy Markdown
Contributor Author

There is an open PR to fix this #1236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants