GH-1300: Use Locale.ROOT when building C Data Interface format strings - #1301
Open
lawofcycles wants to merge 1 commit into
Open
lawofcycles wants to merge 1 commit into
lawofcycles wants to merge 1 commit into
Conversation
…strings Format.asString built the FixedSizeList, FixedSizeBinary and Decimal format strings with String.format and no explicit Locale, so JVMs whose default locale uses digits outside ASCII exported strings such as "+w:٨" that other Arrow implementations cannot parse. Closes apache#1300.
lawofcycles
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
September 19, 2026 17:12
This comment has been minimized.
This comment has been minimized.
lidavidm
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format.asStringbuilt theFixedSizeList(+w:%d),FixedSizeBinary(w:%d) andDecimal(d:%d,%d[,%d]) format strings withString.formatand no explicitLocale.java.util.Formatterlocalises the digits of%dwith the default locale, so a JVM running underar-EG,bn-BD,mr-INand similar locales exported+w:٨instead of+w:8, which arrow-rs and other implementations reject.This passes
Locale.ROOTto the four calls and addsFormatTest.testAsStringIgnoresDefaultLocale, which sets the default locale toar-EGfor the duration of the test and asserts the ASCII output.Closes #1300.