Skip to content

GH-1236: fix out-of-slice read in ArrowFlightJdbcArray.checkBoundaries #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arawoof06 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-1236: fix out-of-slice read in ArrowFlightJdbcArray.checkBoundaries #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix out-of-slice read in ArrowFlightJdbcArray.checkBoundaries
  • Loading branch information
@Arawoof06
Arawoof06 committed Aug 25, 2026
commit 1b1a4f9a7f4c4b46c01a7c05a8fd5289d538f346
2 changes: 1 addition & 1 deletion ...flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public Object getArray(long index, int count) throws SQLException {
}

private void checkBoundaries(long index, int count) {
if (index < 0 || index + count > this.startOffset + this.valuesCount) {
if (index < 0 || index + count > this.valuesCount) {
throw new ArrayIndexOutOfBoundsException();
}
}
Expand Down
14 changes: 14 additions & 0 deletions ...ht-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,20 @@ public void testShouldGetArrayWithOffsetsThrowArrayIndexOutOfBoundsException()
() -> arrowFlightJdbcArray.getArray(0, dataVector.getValueCount() + 1));
}

@Test
public void testShouldGetArrayWithOffsetsNotReadPastEndOfSlice() throws SQLException {
// Array covering elements 5, 6 and 7 of the underlying vector.
ArrowFlightJdbcArray arrowFlightJdbcArray = new ArrowFlightJdbcArray(dataVector, 5, 3);
assertThrows(ArrayIndexOutOfBoundsException.class, () -> arrowFlightJdbcArray.getArray(1, 3));
}

@Test
public void testShouldGetResultSetWithOffsetsNotReadPastEndOfSlice() throws SQLException {
ArrowFlightJdbcArray arrowFlightJdbcArray = new ArrowFlightJdbcArray(dataVector, 5, 3);
assertThrows(
ArrayIndexOutOfBoundsException.class, () -> arrowFlightJdbcArray.getResultSet(1, 3));
}

@Test
public void testShouldGetArrayWithMapNotBeSupported() throws SQLException {
ArrowFlightJdbcArray arrowFlightJdbcArray =
Expand Down
Loading