fix(desktop): apply getComputedStyle polyfill on all platforms - #9369
Merged
adamdotdevin merged 1 commit intoJan 19, 2026
Merged
Conversation
Floating UI can call getComputedStyle with non-elements (e.g., null refs,
virtual elements) on all platforms, not just Windows. This removes the
Windows-only condition so the safety wrapper works on macOS and Linux too.
Fixes TypeError: Argument 1 ('element') to Window.getComputedStyle must be
an instance of Element
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
May 5, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
Rwanbt
pushed a commit
to Rwanbt/unifia
that referenced
this pull request
Jun 14, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
meSingh
pushed a commit
to meSingh/opencode
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating UI can call getComputedStyle with non-elements (e.g., null refs, virtual elements) on all platforms, not just Windows. This removes the Windows-only condition so the safety wrapper works on macOS and Linux too.
Fixes TypeError: Argument 1 ('element') to Window.getComputedStyle must be an instance of Element
What does this PR do?
On MacOS, I got error with the following:
Removes the if (isWindows) condition from the getComputedStyle polyfill in packages/desktop/src/index.tsx
Applies the safety wrapper on all platforms (macOS, Windows, Linux) instead of Windows only
How did you verify your code works?
Tested on local test cases. I can't reproduce this error on desktop version. It pop out sometimes when I continue on a conversation. But I am sure that this error occurs on MacOS.