Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51534
Issue: #51534
Type of change
What does this PR do?
Project.IDaccepts"". Stats previously treated that as a real project ID in both its message SQL and its compaction-event session lookup. The result was an all-zero report, and the inferredfromtime was wrong.Use the same truthiness guard at both sites so an empty project ID means no project filter. Non-empty project IDs keep their existing filter.
How did you verify your code works?
Added a regression assertion in the existing seeded stats test. It compares the full result for
projectID: ""with the result for an omitted project ID, using the same fixed end time. It failed before the fix and passes after it, including the inferred range, usage, and tool totals.bun run test test/session-stats.test.tsinpackages/core: 1 passbun typecheckinpackages/core: passbun run checkat the root: passScreenshots / recordings
No UI change.
Checklist