Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #50986
Type of change
What does this PR do?
Workspace user messages use the theme accent background, but paired it with a foreground meant for a different surface. One Dark Pro dark mode therefore rendered the message at about 1.1:1 contrast. I added an accent foreground token chosen against the resolved accent background and used it for the workspace message and mention prefix. This keeps the accent styling while choosing readable text for bright as well as dark accents. The selector and contrast diagnosis were documented in the issue discussion.
How did you verify your code works?
bun test src/theme/v2/resolve.test.tsinpackages/ui: 84 passed, including all built-in themes in both color schemes and a custom theme fallback.bun typecheckinpackages/ui: passed.bun run check: lint passed with 0 errors and 0 warnings; full typecheck stopped because this worktree lacks theastroexecutable forservices/www.bun run typecheck:e2ereported two errors in untouched performance probe files.MachPortRendezvousServerpermission denied). The expected browser version was unavailable, and downloading it hit the host disk limit.Screenshots / recordings
Before: One Dark Pro workspace screenshot from the issue. The after screenshot in the updated E2E test could not be captured on this host because Chromium was blocked as described above.
Checklist