Skip to content

fix(tui): separate question checkmark labels - #28558

Merged
kitlangton merged 2 commits into
devfrom
fix/question-spacing-regression
May 21, 2026
Merged

kitlangton merged 2 commits into
devfrom
fix/question-spacing-regression

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

  • add explicit spacing before single-select question checkmarks in both TUI question renderers
  • add a render regression test for the direct question footer
  • narrow global event test fixtures so current dev typecheck passes without accepting non-global event payloads

Regression Point

  • introduced in 12b621068a fix(tui): dim question option prefixes (#8776) when the option row gap={1} was removed while the trailing checkmark stayed in a separate adjacent text node
  • the direct run footer copied the same pattern in 7f2b5ee8c2 feat(opencode): add interactive split-footer mode to run (#23557)

Issue Search

  • searched issues/PRs for Product✓, question checkmark, Type your own answer, and TUI question spacing
  • no matching report found

Verification

  • bunx prettier --check packages/opencode/src/cli/cmd/tui/routes/session/question.tsx packages/opencode/src/cli/cmd/run/footer.question.tsx packages/opencode/test/cli/run/footer.view.test.tsx packages/opencode/test/cli/run/stream.transport.test.ts packages/opencode/test/cli/tui/use-event.test.tsx
  • bunx oxlint packages/opencode/src/cli/cmd/tui/routes/session/question.tsx packages/opencode/src/cli/cmd/run/footer.question.tsx packages/opencode/test/cli/run/footer.view.test.tsx
  • bun run test -- --timeout 5000 test/cli/run/footer.view.test.tsx test/cli/tui/use-event.test.tsx
  • bun typecheck
  • pre-push bun turbo typecheck

@kitlangton
kitlangton merged commit ddd6eb4 into dev May 21, 2026
10 checks passed
@kitlangton
kitlangton deleted the fix/question-spacing-regression branch May 21, 2026 01:36
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
isaacfinnegan pushed a commit to isaacfinnegan/whispercode that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant