fix(session): accept empty fork payload#26655
Open
eatFirewood wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26656
Type of change
What does this PR do?
Allows
POST /session/:sessionID/forkto accept an empty request body. Full-session forks callsession.fork({ sessionID }), and the generated SDK omits the body when there is nomessageID. The server previously tried to parse that missing body as JSON and returned400 RequestParseError: JSON Parse error: Unexpected EOF.This keeps the existing
{ messageID }behavior for message-specific forks, but handles no-content bodies as full-session forks.How did you verify your code works?
bun run --cwd packages/opencode typecheckbun run --cwd packages/opencode script/httpapi-exercise.ts --mode effectbun run --cwd packages/opencode script/httpapi-exercise.ts --mode coverage --fail-on-missing --fail-on-skipScreenshots / recordings
N/A, server-side HTTP API fix.
Checklist