feat: enable type-aware no-floating-promises rule, fix all 177 violations#22741
Merged
Conversation
…ions Add oxlint-tsgolint for type-aware linting and enable the no-floating-promises rule. Fix all 177 unhandled promise warnings by adding `void` to intentional fire-and-forget calls (Bus.publish, clipboard, cleanup, async callbacks in sync contexts). This rule prevents silently dropped promise rejections — the #1 async bug pattern in TypeScript codebases.
kitlangton
force-pushed
the
kit/oxlint-floating-promises
branch
from
c7c7ced to
3e427bb
Compare
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Apr 16, 2026
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
dgokeeffe
pushed a commit
to dgokeeffe/opencode-databricks
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxlint-tsgolintfor type-aware linting (uses TypeScript's Go compiler port for full type info)no-floating-promisesrule — catches unhandled promise rejectionsWhy this matters
no-floating-promisesis the single highest-value type-aware lint rule. It catches:awaited,returned, orvoidedWhat was fixed
All 177 hits were intentional fire-and-forget patterns that just needed
voidto signal intent:Bus.publish(...)/ event publishingvoid Bus.publish(Event.Updated, {...})void sdk.client.session.create(...)void Log.init(...),void server.stop()navigator.clipboardvoid navigator.clipboard.writeText(...)mock.module(...)in testsvoid mock.module(...)No code was restructured — only
voidwas added to make the intent explicit.Performance
Type-aware linting adds ~7s to the lint run (vs ~140ms syntax-only) since it needs to build the type graph. This is still much faster than ESLint + typescript-eslint would be (~30-60s on a codebase this size).