remove makeRuntime facade from Env - #22523
Merged
Merged
Conversation
Remove the standalone makeRuntime + facade functions (Env.get, Env.set, Env.all, Env.remove) from src/env/index.ts. Add Env.defaultLayer to AppLayer so Env.Service is available through AppRuntime. Test callers now use a local shorthand backed by AppRuntime.runPromise(Env.Service.use(...)) instead of the deleted sync facades.
kitlangton
marked this pull request as ready for review
April 15, 2026 14:55
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jun 10, 2026
isaacfinnegan
pushed a commit
to isaacfinnegan/whispercode
that referenced
this pull request
Jun 15, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeRuntime+ facade functions (Env.get,Env.set,Env.all,Env.remove) fromsrc/env/index.tsEnv.defaultLayertoAppLayersoEnv.Serviceis available throughAppRuntimeAppRuntime.runPromise(Env.Service.use(...))Changes
src/env/index.tsmakeRuntimeimport and 4 facade functions (19 lines deleted)src/effect/app-runtime.tsEnvimport andEnv.defaultLayertoAppLayertest/provider/provider.test.tssetshorthand, replaced ~59Env.set(...)calls withawait set(...)test/provider/amazon-bedrock.test.tssetshorthand, replaced ~15Env.set(...)calls withawait set(...)All typechecks and tests pass.