3.7.1 Updated to gulp.js 4.0.x - #840
Closed
warengonzaga wants to merge 42 commits into
Closed
Conversation
Merge branch 'master' of https://github.com/daneden/animate.css Merge branch 'master' of https://github.com/daneden/animate.css
Collaborator
|
I don’t think there's any action required here actually @warengonzaga: I commented on #834 mentioning that your rebase to master seemed to fix conflicts and everything is working fine now. Looks like this PR just updates package-lock.json, which I don’t think is necessary here and I'd rather not cause thrash with another minor release. |
Collaborator
|
@warengonzaga additionally, for future PRs you might consider forking again or updating from this repo's master branch since it looks like your pull requests are bringing a ton of old commits with them! |
Member
Author
|
@daneden can you please include in the 3.7.0 release that we are already in GULP.JS 4 :) you forgot it. |
Member
Author
|
Alright, @daneden will do it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @daneden I manage to fix the conflicts... I am confused with the rebase where should I start. So I get the latest copy from you guys by using upstream. So let me know if this pull request is good?