Skip to content

3.7.0 New Feature: Animation Speed & Animation Delay Classes - #834

Merged
daneden merged 39 commits into
animate-css:masterfrom
warengonzaga:master
Jul 23, 2018
Merged

3.7.0 New Feature: Animation Speed & Animation Delay Classes#834
daneden merged 39 commits into
animate-css:masterfrom
warengonzaga:master

Conversation

@warengonzaga

@warengonzaga warengonzaga commented Jul 20, 2018

Copy link
Copy Markdown
Member

I made a huge update here, I upgrade our gulp version to gulp 4 which has breaking changes...
I remove the runSequence because it is no longer needed since gulp.series is now available.

Check this: https://github.com/gulpjs/gulp/blob/4.0/docs/API.md

I just update the following dev-dependencies...

  • autoprefixer
  • cssnano
  • eslint

New Feature: Animation Speed Classes

  • Slow
  • Slower
  • Fast
  • Faster

New Feature: Animation Delay Classes

  • Delay-2s to Delay-5s

I change the version from 3.7.0 to 3.7.1 because I did some bug fixing due to upgrading the gulp to gulp 4 and it supports the latest Node.js version.

@warengonzaga warengonzaga changed the title Update DevDependencies New Feature: Animation Speed & Update DevDependencies Jul 21, 2018
@daneden daneden changed the title New Feature: Animation Speed & Update DevDependencies 3.7.0 New Feature: animation speed & update devdependencies Jul 21, 2018
@daneden

daneden commented Jul 21, 2018

Copy link
Copy Markdown
Collaborator

This looks mostly good, you'll need to rebase since there've been some changes this morning!

Is it odd that there are commits in this PR from December 2017?

@daneden

daneden commented Jul 21, 2018

Copy link
Copy Markdown
Collaborator

I guess we can squash the commits when we merge. Just rebase and this should be good to go, and I can write & publish the 3.7.0 tag.

@warengonzaga

Copy link
Copy Markdown
Member Author

Thanks, @daneden for the update... there is a fail in building it at node 8 to 9 I need to fix it first. How can I rebase it where should I rebase it? What commit?

@warengonzaga warengonzaga changed the title 3.7.0 New Feature: animation speed & update devdependencies 3.7.1 New Feature: Animation Speed Jul 23, 2018
@warengonzaga warengonzaga changed the title 3.7.1 New Feature: Animation Speed 3.7.1 New Feature: Animation Speed & Animation Delay Classes Jul 23, 2018
@warengonzaga

Copy link
Copy Markdown
Member Author

Hello @daneden I manage to update the code of animate.css... I fix all the errors... also as a plus I update the gulp version to gulp 4 so there are small changes in the gulpfile. I just remove the deprecated runSequence and change it to gulp.series. I'm gonna follow what you need.

@warengonzaga

Copy link
Copy Markdown
Member Author

Hello @daneden where should I rebase it? Here's the screenshot of git log...
image

Before I add the changes, I am sure that I have the most recent codes...

@daneden

daneden commented Jul 23, 2018

Copy link
Copy Markdown
Collaborator

Let's stick with 3.7.0 as the release number since we haven't yet made that so it wouldn't make sense to release 3.7.1 😄

It looks like the merge conflicts are resolved now: I was just asking for a rebase to help fix the conflicts.

@daneden daneden changed the title 3.7.1 New Feature: Animation Speed & Animation Delay Classes 3.7.0 New Feature: Animation Speed & Animation Delay Classes Jul 23, 2018
@daneden
daneden merged commit be8582a into animate-css:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants