Removed outOfBounds variable#856
Conversation
…i-tree into issue-622 # Conflicts: # source/directives/uiTreeNode.js
|
@herumtreiber thanks for your work! Can you remove the files in |
This reverts commit a5e9e4a.
|
@Voles no problem. I reverted my commit with the dist files. We are using a version with the change in our project at the moment and I couldn't see any negative impacts on the component, yet. I guess that the outOfBounds variable was introduced for performance reasons, but I didn't experience a negative effect on the overall performance either. We are using the component for drag and drop between multiple trees and also to create hierarchies. |
|
Hey @Voles , any news about the status of this pull request? |
|
@herumtreiber thanks very much for your time and effort! I'll create a new release soon. |
|
Thank you! :) |
|
Woohoo! That was quick! Thanks a lot! :) |
ghost
mentioned this pull request
3 participants
Hey,
I found several bugs that are caused by the calculation of outOfBounds not working correctly. The PR #739 was committed to remove the faulty implementation and resolve at least #622 and #763 .
The pull request was unfortunately never merged since it contained merge conflicts. I resolved the conflicts since I really need this fix for our project. I did not test all possible impacts the removing of the variable might have, though.
best,
Sven