Conversation
|
@Jefiozie @SanderElias Maybe it is time to change the prettier configuration? |
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
I'm ok with this PR, but please update the description a bit, so we can address it properly when merging.
| if (logsEl.nativeElement.scroll) { | ||
| (<HTMLElement>logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 }) | ||
| const element = logsEl.nativeElement as HTMLElement | ||
| element.scroll({ top: this.logMessages.length * 30 }) |
There was a problem hiding this comment.
Like it, but it doesn't have to do with prettier? Perhaps update the pr description for the other things.
There was a problem hiding this comment.
Due to semi false prettier adds with the previous way a ; at the beginning which is then marked by eslint.
The solution is either to separate like I did here or change semi to true
| if (logsEl.nativeElement.scroll) { | ||
| (<HTMLElement>logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 }) | ||
| const element = logsEl.nativeElement as HTMLElement | ||
| element.scroll({ top: this.logMessages.length * 30 }) |
There was a problem hiding this comment.
Same here.
I don't mind those better typings, but it is very drive-by
There was a problem hiding this comment.
Pull request overview
Updates the repository’s formatting toolchain by bumping Prettier and applying the resulting formatting changes across a few TS/HTML/YAML/MD files.
Changes:
- Bump
prettierfrom^3.0.2to^3.8.1and updatepackage-lock.jsonaccordingly. - Add an npm script (
prettier) and apply Prettier-driven formatting updates (TS casting style, Angular template trailing comma, YAML indentation/quoting, MD whitespace).
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/app/examples/split-transitions/split-transitions.component.ts |
Refactors type casting for nativeElement to align with updated formatting output. |
src/app/examples/gutter-click-roll-unroll/gutter-click-roll-unroll.component.ts |
Same casting refactor for log auto-scroll code. |
projects/angular-split/src/lib/split/split.component.html |
Prettier formatting adjustment in ngTemplateOutlet context object (trailing comma). |
package.json |
Updates Prettier version and adds a prettier --write . script. |
package-lock.json |
Locks Prettier to 3.8.1 with updated resolved/integrity metadata. |
CONTRIBUTING.md |
Removes an extraneous blank line/whitespace in the guidelines list. |
.github/workflows/license.yml |
Normalizes YAML indentation and quoting; removes trailing whitespace. |
.github/workflows/dependency-review.yml |
No functional change; formatting/whitespace normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I am not sure what to add... It was only prettier version update and run it on all files |
|
@Harpush I just noticed that the type improvements also came from there. Surprising. But I'm fine with this. |
|
@SanderElias so do you want to merge or change semi to false? Or maybe more changes to prettier settings like print width back to 80? |
No description provided.