Remove widgets by widget id within the definition object#330
Open
sparksterz wants to merge 1 commit intoangular-dashboard-framework:masterfrom
Open
Remove widgets by widget id within the definition object#330sparksterz wants to merge 1 commit intoangular-dashboard-framework:masterfrom
sparksterz wants to merge 1 commit intoangular-dashboard-framework:masterfrom
Conversation
This fixes an edge type use case where someone editing a dashboard adds multiple of the same widget within the same column. Once removed, it doesn't find an index in subsequent removals of the same widget type, but it does remove it from the dashboard. As a result, the visual state of the widgets in a column differs (visual state removes widgets) from the object (subsequent widgets of the same type stay in the column after the first removal), unless using the widget id to identify a unique entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an edge type use case where someone editing a dashboard adds multiple of the same widget within the same column. Once removed, it doesn't find an index in subsequent removals of the same widget type, but it does remove it from the dashboard. As a result, the visual state of the widgets in a column differs (visual state removes widgets) from the object (subsequent widgets of the same type stay in the column after the first removal), unless using the widget id to identify a unique entry.