Conversation
Attemps to fix the Safari failure that showed up on CI.
crisbeto
force-pushed
the
safari-task-state
branch
from
October 2, 2026 13:45
49b25fd to
3f40f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a harness via
harnessForFixture, we awaitenvironment.forceStabilize()before creating the component harness and its child environment. In newer versions of Safari, resuming from nativeawaitcan escape the test zone back to the root zone. This caused child environments created afterwards to fail theisInProxyZone()check and omit_taskState, preventingwaitForTasksOutsideAngularfrom tracking async tasks scheduled outside Angular.These changes resolve the issue by propagating the task state from the parent
TestbedHarnessEnvironmentdown to child environments created viacreateEnvironment.