fix(material/form-field): measure labels independently of the outline notch - #33912
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
… notch Measure the intrinsic label width before updating the notch to avoid slow feedback loops with truncated flex content. Restore inline styles after measurement and cover resizing in both text directions. Fixes angular#33207
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33207
Measure the label independently of the current outline notch, then restore its inline styles. This stops truncated flex labels from expanding one pixel per resize callback when the field grows; the existing ResizeObserver scheduling stays in place.
The regression fails before the fix. Input and Select suites pass in Chromium and Firefox, including TypeScript compilation; coverage includes LTR/RTL resizing and inline style preservation. Scoped type-aware TSLint and the repository formatter pass.