fix(material/sidenav): scope transitions to the nearest drawer container - #33911
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
Keep a nested drawer from inheriting an outer container animation during its initial render. Preserve transitions once its own container enables them. Fixes angular#33080
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
crisbeto
reviewed
Oct 1, 2026
| } | ||
|
|
||
| .mat-drawer-container { | ||
| // Scope transition timing to the nearest container so an outer container cannot animate |
Member
There was a problem hiding this comment.
AFAIK we don't officially support nesting drawers/drawer containers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33080
An initialized outer drawer container can enable transitions on a newly rendered inner drawer through the descendant selectors. Scope the transition duration to the nearest container so nested drawers skip their initial transition and animate after their own container enables transitions.
Added a regression covering the nested drawer, content, and backdrop before and after initialization. It fails before the fix; the sidenav suites now pass in Chromium and Firefox, including TypeScript compilation. Scoped stylelint, TSLint, and the repository's staged formatter passed.