Conversation
… changes In angular#31643 we added a workaround that copied `Directionality.valueSignal` into a property through an `effect`, because reading the signal inside an `afterRenderEffect` was causing a memory leak (angular/angular#62980). As a side effect, the `afterRenderEffect` that positions the label of an outlined form field with a prefix no longer depended on the direction, so the label offset wasn't recalculated if the direction changed at runtime. The framework issue was fixed in angular/angular#63001 so these changes remove the workaround and read the direction directly again.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #31643 we added a workaround that copied
Directionality.valueSignalinto a property through aneffect, because reading the signal inside anafterRenderEffectwas causing a memory leak (angular/angular#62980). As a side effect, theafterRenderEffectthat positions the label of an outlined form field with a prefix no longer depended on the direction, so the label offset wasn't recalculated if the direction changed at runtime.The framework issue was fixed in angular/angular#63001 so these changes remove the workaround and read the direction directly again.