refactor: use relative imports within npm packages - #30588
Merged
Merged
Conversation
andrewseguin
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
March 5, 2025 20:07
andrewseguin
added
the
target: patch
crisbeto
reviewed
Mar 5, 2025
|
|
||
| import {ObserversModule} from '@angular/cdk/observers'; | ||
| // @ng_package: ignore-cross-repo-import | ||
| import {ObserversModule} from '../observers'; |
Member
There was a problem hiding this comment.
I was under the impression that cross-package imports should still be absolute?
Contributor
Author
There was a problem hiding this comment.
I checked with @devversion to confirm that everything within src/material should be relative to each other since they are all shared under the @angular/material npm package. Likewise with cdk
andrewseguin
force-pushed
the
pkg
branch
7 times, most recently
from
March 7, 2025 14:00
1412665 to
72655a7
Compare
crisbeto
approved these changes
Mar 11, 2025
andrewseguin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using relative imports within directories under the broad npm packages like
@angular/materialand@angular/cdk.