Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): always pass in the model value to ctrl.$isEmpty - #9017

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:checkboxrequired
Closed

tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:checkboxrequired

Conversation

@tbosch

@tbosch tbosch commented Sep 10, 2014

Copy link
Copy Markdown
Contributor

Fixes #5164

@tbosch

tbosch commented Sep 10, 2014

Copy link
Copy Markdown
Contributor Author

Closes #8979

Comment thread src/ng/directive/input.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to reword as "an empty checkbox is never equal to the trueValue"?

@jeffbcross

Copy link
Copy Markdown
Contributor

Some docs comments but otherwise LGTM

@tbosch tbosch closed this Sep 10, 2014
@tbosch
tbosch deleted the checkboxrequired branch September 10, 2014 18:46
tbosch added a commit that referenced this pull request Sep 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng-required conflicts with ng-true-value

3 participants