This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
Conversation
Narretz
force-pushed
the
fix-checkbox-required
branch
from
September 9, 2014 18:17
0bd4f6e to
1d47b0b
Compare
Narretz
force-pushed
the
fix-checkbox-required
branch
from
September 9, 2014 18:18
1d47b0b to
ad86241
Compare
Contributor
|
Hie @Narretz, I think we need a different PR: |
Contributor
|
Landed your tests with my changes to the implementation in master, 3e51b84 |
Contributor
Author
|
👍 : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5164
The viewValue in a checkbox is always set to false (by default). Comparing to the trueValue is therefore incorrect.