Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): make maxlength and minlength work with non-string values - #8205

Closed
ssergio198 wants to merge 2 commits into
angular:masterfrom
ssergio198:master
Closed

ssergio198 wants to merge 2 commits into
angular:masterfrom
ssergio198:master

Conversation

@ssergio198

Copy link
Copy Markdown
Contributor

Request Type: bug

How to reproduce:

Component(s): misc core

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Other Comments:

Validity for inputs with maxlength attribute and an underlying non-string model value is always false: e.g. the length property for a numeric data type returns undefined

@mary-poppins

Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8205)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz

Narretz commented Jul 15, 2014

Copy link
Copy Markdown
Contributor

Duplicate of #7968

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants