Repository navigation
fixed email regexp - #7944
fixed email regexp#7944saifanam wants to merge 1 commit into
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I signed once again @mary-poppins. Could you please check? Thanks. |
|
@saifanam There is simply no easy way to have an email regex that would make everybody happy. Issues like the fact that html5 email regex is different than RFC5322 (http://www.w3.org/TR/html5/forms.html#valid-e-mail-address) does not make it any easier. The current email regex is closer to what people understand an email address is. Would it be possible to understand why the need to tweak it? |
|
i think that regex in w3.org is probably closer to correct... |
|
the existing code regex looks the same as the webkit implementation i guess a test or showing what is not working with the existing implementation as @lgalfaso suggested is probably a good call... sorry if this was obvious to others, but I had to do some digging for context :) |
|
@saifanam can you please add some tests to this? |
02dc2aa to
fd2d6c0
Compare
cad9560 to
f294244
Compare
|
Closing this for the time being since it's been a few months since any activity happened. Please open a new issue if the bug is still relevant. |
No description provided.