Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fixed email regexp - #7944

Closed
saifanam wants to merge 1 commit into
angular:masterfrom
saifanam:email_regex
Closed

saifanam wants to merge 1 commit into
angular:masterfrom
saifanam:email_regex

Conversation

@saifanam

Copy link
Copy Markdown

No description provided.

@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@saifanam saifanam added cla: no and removed cla: yes labels Jun 23, 2014
@saifanam

Copy link
Copy Markdown
Author

I signed once again @mary-poppins. Could you please check? Thanks.

@lgalfaso

Copy link
Copy Markdown
Contributor

@saifanam There is simply no easy way to have an email regex that would make everybody happy. Issues like the fact that html5 email regex is different than RFC5322 (http://www.w3.org/TR/html5/forms.html#valid-e-mail-address) does not make it any easier.

The current email regex is closer to what people understand an email address is. Would it be possible to understand why the need to tweak it?

@ealtenho ealtenho mentioned this pull request Jun 23, 2014
@rolfyone

Copy link
Copy Markdown
Contributor

i think that regex in w3.org is probably closer to correct...
the proposed regex would have the up side of allowing [email protected] I guess, but that is equally valid in the w3.org regex... is there a reason why we don't use either RFC5322 or the w3.org regex?

@rolfyone

Copy link
Copy Markdown
Contributor

the existing code regex looks the same as the webkit implementation
http://trac.webkit.org/browser/trunk/Source/WebCore/html/EmailInputType.cpp?rev=86298

i guess a test or showing what is not working with the existing implementation as @lgalfaso suggested is probably a good call... sorry if this was obvious to others, but I had to do some digging for context :)

@matsko

matsko commented Aug 28, 2014

Copy link
Copy Markdown
Contributor

@saifanam can you please add some tests to this?

@matsko

matsko commented Oct 7, 2014

Copy link
Copy Markdown
Contributor

Closing this for the time being since it's been a few months since any activity happened. Please open a new issue if the bug is still relevant.

@matsko matsko closed this Oct 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants