Repository navigation
Update step_07.ngdoc - #7099
Update step_07.ngdoc#7099RobertKielty wants to merge 1 commit into
Conversation
I attempted to tighten up the language around the DI overview so that it was clearer and more explicit. The sole responsibilities sentence was semantically jarring and I think looks better as a list. Some minor grammar improvements. I had no way of proofing final appearance so apologies if I have got any formatting wrong.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
1 similar comment
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I signed the agreement. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
@RobertKielty - the way to proof the final result is to do: Then browse to http://localhost:8000/build/docs/ |
I attempted to tighten up the language around the DI overview so that it was clearer and more explicit. The sole responsibilities sentence was semantically jarring and I think looks better as a list. Some minor grammar improvements. Closes #7099
I attempted to tighten up the language around the DI overview so that it was clearer and more explicit. The sole responsibilities sentence was semantically jarring and I think looks better as a list. Some minor grammar improvements. Closes angular#7099
I attempted to tighten up the language around the DI overview so that it was clearer and more explicit. The sole responsibilities sentence was semantically jarring and I think looks better as a list. Some minor grammar improvements. I had no way of proofing final appearance so apologies if I have got any formatting wrong.