Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): Allow ng-true-value and ng-required on a checkbox - #6876

Closed
lgalfaso wants to merge 1 commit into
angular:masterfrom
lgalfaso:issue-6875
Closed

lgalfaso wants to merge 1 commit into
angular:masterfrom
lgalfaso:issue-6875

Conversation

@lgalfaso

Copy link
Copy Markdown
Contributor

Put the input[checkbox] formatter and parser first in the $formatters and $parsers queue so they are the first being called when formatting and the last when parsing. This allows the existing logic at ng-required (that uses $isEmpty) to work on the ng-true-value value

Closes #6875

Put the input[checkbox] formatter and parser first in the $formatters
and $parsers queue so they are the first being called when formatting
and the last when parsing

Closes angular#6875
@mary-poppins

Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6876)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@lgalfaso

Copy link
Copy Markdown
Contributor Author

This is a dup of #6065. Closing

@lgalfaso lgalfaso closed this Mar 27, 2014
@lgalfaso
lgalfaso deleted the issue-6875 branch March 28, 2014 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using ng-true-value in conjunction with ng-required fails to pass value to model

2 participants