Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Form $attempted status - #5574

Closed
nicoabie wants to merge 2 commits into
angular:masterfrom
nicoabie:form_attempted
Closed

nicoabie wants to merge 2 commits into
angular:masterfrom
nicoabie:form_attempted

Conversation

@nicoabie

Copy link
Copy Markdown
Contributor

A contribution to issue #583

Added new state to form:
- it sets to true when form submitted having $invalid state
- it sets back to false when form submitted having valid state
@ghost ghost assigned tbosch and matsko Dec 31, 2013
@IgorMinar

Copy link
Copy Markdown
Contributor

I think that 'attempted' is not the best name, can we think of something better?

@nicoabie

nicoabie commented Jan 3, 2014

Copy link
Copy Markdown
Contributor Author

Hi @IgorMinar, thanks for your reply.
The other adjective I can think of is 'rejected'.

@troch

troch commented Jan 19, 2014

Copy link
Copy Markdown

@IgorMinar @nicoabie exposed?

@nicoabie

Copy link
Copy Markdown
Contributor Author

@troch It could be.

@matsko

matsko commented Jun 3, 2014

Copy link
Copy Markdown
Contributor

For AngularDart we use $submitted.

@matsko

matsko commented Jul 1, 2014

Copy link
Copy Markdown
Contributor

@nicoabie can you squash both commits together and use $submitted instead of attempted?

Also, when $setPristine is called on the form, it should revert the $submitted back to false.

@nicoabie

nicoabie commented Jul 2, 2014

Copy link
Copy Markdown
Contributor Author

@matsko will do it tonight, Argentina time. thanks for the clarification.

@matsko

matsko commented Jul 2, 2014

Copy link
Copy Markdown
Contributor

Excellent :)

@nicoabie

nicoabie commented Jul 3, 2014

Copy link
Copy Markdown
Contributor Author

@matsko I opened a new pull request, need to get better at git commands.

#8056

@nicoabie nicoabie closed this Jul 3, 2014
@nicoabie
nicoabie deleted the form_attempted branch July 3, 2014 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants