This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
Conversation
do not link to parent form if `not-required` attr is defined on the (ng)form element
Author
|
Do let me know if there is anything I can do to speed up inclusion of this or similar feature into mainline, I'd love to dispense with the fork. Thanks |
|
Exactly what i need, my patch is the same:
parentForm = typeof attrs.dontBubble == 'undefined' && element.parent().controller('form') || nullFormCtrl, |
Contributor
|
related #5858 |
This was referenced May 28, 2014
Contributor
|
The new behavior needs a test. There's also the issue that the child form's submit event will bubble up the DOM to the parent form, which is undesired. |
Author
|
I'm not in ng-world currently so won't be doing anything about it for foreseeable future. Recommend other interested parties reopen / make a new ticket. Thanks |
|
👍 |
1 similar comment
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements ability to prevent FormController from linking to parentForm if
not-requiredattr is defined on the[ng-]formelement.It is useful for scenario like below, where
auxsubform can be independently validated without invalidatingparentform. Without this patch (andnot-requiredon the subforms), master "Save" button is disabled when aux input fields are not filled out. Idea is to use them only temporarily before adding to master model and then clears them out.Alternatively, if subform inputs are not marked as required, then subform "Add" buttons will always be enabled. Options are either user or programmer un-friendly.
(The only workaround I found is to use
ng-ifon the subform to add it to DOM only when requested, but often we need subforms visible all the time, and we can't place them elsewhere in the DOM.)