fix(input): keep track of min/max attrs on-the-fly - #4553

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

CLA / Real name is Dmitry Shirokov [email protected]

LGTM

@matsko this is assigned to you. are you waiting for something before merging it? I'm not going to merge it now in case you are waiting for something...

@IgorMinar Yup. Merging it now. At the time I couldn't verify the CLA thing.

MERGED

Landed as 4b653ae

This does not re-validate the value when changing min/max.
Does not test form-validity.

If i change min/max the control is still valid even if the value is out of range.

And input[type=button] ?

@quazzie could you show your code please? On the jsfiddle or somewhere else.

http://plnkr.co/edit/cVOninI9I1451PHYJUWG?p=preview

#4788

@quazzie I figured out why this worked for me - I changed the model's value at the same time with the min's value. It triggers the $setViewValue method when you do so.

@quazzie there is alternative solution #4797.

I have a feeling that this trick with $setViewValue methods looks like a hack.. @matsko any thoughts?

@runk yeah that's maybe a nicer way to do it. But please add the tests.
The only thing i can complain about is that your solution uses 2 'watches'.

Yeah, sure @quazzie. It looks like that tests work fine.