Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(form): do not prevent submit when action attribute equals to an empty string - #3776

Closed
agentcooper wants to merge 1 commit into
angular:masterfrom
agentcooper:form-action-fix
Closed

fix(form): do not prevent submit when action attribute equals to an empty string#3776
agentcooper wants to merge 1 commit into
angular:masterfrom
agentcooper:form-action-fix

Conversation

@agentcooper

@agentcooper agentcooper commented Aug 28, 2013

Copy link
Copy Markdown

Closes #3370

@petebacondarwin

petebacondarwin commented Sep 18, 2013

Copy link
Copy Markdown
Contributor

@agentcooper - Thanks for the PR!
The content of the commit LGTM.
Can you ensure you have signed the CLA.
Also, the commit message subject is too long. Can you fix it up?

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@ghost ghost assigned petebacondarwin Sep 18, 2013
Artem Tyurin
fix(form): fix submit prevention
2f77a4f 
Do not prevent submit when action
attribute equals to an empty string.

Closes #3370
@agentcooper

agentcooper commented Sep 19, 2013

Copy link
Copy Markdown
Author

Real name for the CLA: Artem Tyurin

@Narretz Narretz modified the milestones: 1.3.0, Backlog Jun 25, 2014
@Narretz Narretz mentioned this pull request Jun 25, 2014
Closed
@Narretz

Narretz commented Jul 9, 2014

Copy link
Copy Markdown
Contributor

I'd like to bump this for one of the next releases, but we should add a test for new case in formSpec.js

@btford btford removed the gh: PR label Aug 20, 2014
@Narretz Narretz mentioned this pull request Sep 9, 2014
Closed
@tbosch tbosch self-assigned this Sep 9, 2014
@Narretz Narretz mentioned this pull request Sep 15, 2014
Closed
@caitp

caitp commented Sep 15, 2014

Copy link
Copy Markdown
Contributor

I guess it looks okay, it's a bit of a breaking change but I don't think it's likely to hurt anyone -- personally I would just say if (!isString(attr.action)) though

IgorMinar
IgorMinar reviewed Oct 2, 2014
View reviewed changes
Comment thread test/ng/directive/ngEventDirsSpec.js

@IgorMinar IgorMinar Oct 2, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not right. the point of the test is to simulate conditions when the form is being submitted. which means that we need the action attribute set to something

@IgorMinar

IgorMinar commented Oct 2, 2014

Copy link
Copy Markdown
Contributor

I fixed this PR and merged it in. thanks!

@IgorMinar IgorMinar closed this in 86c7d12 Oct 2, 2014
@fabiocarneiro fabiocarneiro mentioned this pull request Apr 2, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@tbosch tbosch

Labels

branch: 1.2.x cla: yes component: forms frequency: low type: bug

Projects

None yet

Milestone

1.3.x - superluminal-nudge

Development

Successfully merging this pull request may close these issues.

Form submit prevention changes

7 participants

@agentcooper @petebacondarwin @Narretz @caitp @IgorMinar @btford @tbosch