This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Contributor
Errors I've documented so far: - `$injector:cdep` - `$injector:itkn` - `$injector:modulerr` - `$injector:nomod` - `$injector:pget` - `$injector:unpr` - `ng:areq` - `ng:cpi` - `ng:cpws` - `ngModel:noass`
Contributor
Author
|
The PR closed itself. Interesting. Maybe we could add a pre-commit hook to make all PRs self-closing when merged. Probably that's a bad idea. Really what we need is a rebase button. |
Contributor
|
If you put 'closes #1234' in your commit msg then github automatically close the relevant PR when the commit hits master. |
Contributor
Author
|
I get that, but I didn't put that in my commit msg. It looks like Igor did it for me. |
Contributor
|
it closed because I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors I've documented so far:
$injector:cdep$injector:itkn$injector:modulerr$injector:nomod$injector:pget$injector:unprng:areqng:cping:cpwsngModel:noassThis is an incomplete list and should be considered a WIP until the team has gone through the error doc spreadsheet.