You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
feat(input): Allow postponing model update until input blur event by specifying ng-update-on="blur" so validation doesn't show up while user is still typing - #1783
Can you specifically comment on what needs to be done before it can get merged? Some of the un-checked checkboxes above don't seem to apply. For example, I have signed the CLA, I do think the PR improves existing core functionality, and please let me know if the PR failed ci.angularjs.org (and why/details), etc.
@patgannon Thnx for the update.
The 2 main remaining points are documentation and commit message.
We will execute tests on all browsers just before merging so don't worry about this for now.
Just to note #2129 is similar but has some more functionality - it allows multiple events (including the Angular defaults) and also throttling of updates based on a time period.
Ok, sorry for the delay. I've added documentation for the ngUpdateOn directive. I attached the documentation to the textInputType() function, because I didn't see a better place to put it. Please advise if that's not the right place.
Hi @patgannon - thank you for your work on this PR but as @symblify points out there is a more complete solution offered in #2129, which I think is more likely to be merged. Do you think you could take a look at that and, using your experience of creating this PR, make comments or suggestions to get that up to a workable solution?
Thanks, Pete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.