This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(form): improve the docs for FormController.$setValidity()#15984
Closed
gkalpak wants to merge 3 commits intoangular:masterfrom
Closed
docs(form): improve the docs for FormController.$setValidity()#15984gkalpak wants to merge 3 commits intoangular:masterfrom
FormController.$setValidity()#15984gkalpak wants to merge 3 commits intoangular:masterfrom
Conversation
Narretz
approved these changes
May 12, 2017
Contributor
Narretz
left a comment
Narretz
left a comment
There was a problem hiding this comment.
Just a typo and a wording suggestion, otherwise LGTM
| * pending validators, where: | ||
| * | ||
| * - keys are validations tokens (error names). | ||
| * - values are arrays of controls or forms that have a pending validator fot the given error name. |
| * | ||
| * Application developers will rarely need to call this method directly. It is used internally, by | ||
| * {@link ngModel.NgModelController#$setValidity NgModelController.$setValidity()}, to propagate a | ||
| * control's validity state to parent `FormControllers`. |
Contributor
There was a problem hiding this comment.
I would say "to the parent FormController" because it currently sounds a bit like a control can have multiple direct parent FormControllers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
Bad docs for
FormController.$setValidity().What is the new behavior (if this is a feature change)?
Better docs for
FormController.$setValidity().Does this PR introduce a breaking change?
No
Tests for the changes have been added (for bug fixes / features)Other information:
Fixes #15963.