This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($controller): remove the option to instantiate controllers from c…#15762
Merged
Conversation
…onstructors on `window` This also removes the likewise deprecated `$controllerProvider.allowGlobals()` method. Closes angular#15349 BREAKING CHANGE: The option to instantiate controllers from constructors on the global `window` object has been removed. Likewise, the deprecated `$controllerProvider.allowGlobals()` method that could enable this behavior, has been removed. This behavior had been deprecated since AngularJS v1.3.0, because polluting the global scope is bad. To migrate, remove the call to $controllerProvider.allowGlobals() in the config, and register your controller via the Module API or the $controllerProvider, e.g. ``` angular.module('myModule', []).controller('myController', function() {...}); angular.module('myModule', []).config(function($controllerProvider) { $controllerProvider.register('myController', function() {...}); }); ```
mgol
approved these changes
Feb 28, 2017
gkalpak
approved these changes
Mar 1, 2017
Member
gkalpak
left a comment
gkalpak
left a comment
There was a problem hiding this comment.
There is also a section in the phonecat tutorial that refers to global controllers. It is not exactly clear what it refers to (does it refer to allowGlobals or a hypothetical non-AngularJS app that defines controllers as globals), but it is weird enough and maybe could be removed along with allowGlobals().
Either way LGTM (as long as Travis si happy).
Contributor
Author
|
Thanks for the reviews - also feel free to re-start stalled Travis tests ;) We should probably remove the section about global controllers from the tutorial. |
Contributor
Author
|
I've removed the section about global controllers from the tutorial, PTAL |
mgol
approved these changes
Mar 1, 2017
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
The removed tutorial section was also using manual construction that bypasses the DI so it was really bad anyway.
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
This also removes the likewise deprecated `$controllerProvider.allowGlobals()` method. Closes angular#15349 Closes angular#15762 BREAKING CHANGE: The option to instantiate controllers from constructors on the global `window` object has been removed. Likewise, the deprecated `$controllerProvider.allowGlobals()` method that could enable this behavior, has been removed. This behavior had been deprecated since AngularJS v1.3.0, because polluting the global scope is bad. To migrate, remove the call to $controllerProvider.allowGlobals() in the config, and register your controller via the Module API or the $controllerProvider, e.g. ``` angular.module('myModule', []).controller('myController', function() {...}); angular.module('myModule', []).config(function($controllerProvider) { $controllerProvider.register('myController', function() {...}); }); ```
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onstructors on
windowThis also removes the likewise deprecated
$controllerProvider.allowGlobals()method.Closes #15349
BREAKING CHANGE:
The option to instantiate controllers from constructors on the global
windowobjecthas been removed. Likewise, the deprecated
$controllerProvider.allowGlobals()method that could enable this behavior, has been removed.
This behavior had been deprecated since AngularJS v1.3.0, because polluting the global scope
is bad. To migrate, remove the call to $controllerProvider.allowGlobals() in the config, and
register your controller via the Module API or the $controllerProvider, e.g.