Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

component() helper changes - #13741

Merged
petebacondarwin merged 0 commit into
angular:masterfrom
petebacondarwin:element-only-component
Jan 12, 2016
Merged

petebacondarwin merged 0 commit into
angular:masterfrom
petebacondarwin:element-only-component

Conversation

@petebacondarwin

Copy link
Copy Markdown
Contributor

No description provided.

@gkalpak

gkalpak commented Jan 11, 2016

Copy link
Copy Markdown
Member

The docs still seem to imply that restrict: 'E' is just a configurable default (rather than an enforced value). Maybe we should be more explicit about it being non-configurable (e.g. remove the default behavior like part).

LGTM otherwise.

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

OK, I'll improve the docs.

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jan 12, 2016
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jan 12, 2016
@petebacondarwin
petebacondarwin merged commit 90975db into angular:master Jan 12, 2016
@Mischi

Mischi commented Jan 14, 2016

Copy link
Copy Markdown

removing the ability to set the restrict option makes angular.component()'s unusable with the new ngComponentRouter until the router will support elements next to attributes ...

See #13603 and angular/angular#5278

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@Mischi that is actually a problem with the router that needs to be fixed. @btford ?

@AIMMOTH

AIMMOTH commented Jan 19, 2016

Copy link
Copy Markdown

Why remove element? How do you preserve DOM structure which is important for SEO?

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@AIMMOTH not sure I understand what you mean.

@AIMMOTH

AIMMOTH commented Jan 25, 2016

Copy link
Copy Markdown

@petebacondarwin Recommendations is that the DOM structure should be arranged for SEO. For instance <article></article> should be used. If this article is a component, it was possible to add the component as attribute <article component></article> but now you need to destroy DOM structure with <component></component>

Or have I missed something?

@petebacondarwin
petebacondarwin deleted the element-only-component branch November 24, 2016 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants