add $hasFocus or $focused to forms

just like we have $pristine and $dirty it would be great if we also allowed binding to $focus and $notFocused.

+1

+1 👍 Already implemented in my app :)

As part of our effort to clean out old issues, this issue is being automatically closed since it has been inactivite for over two months.

Please try the newest versions of Angular (1.0.8 and 1.2.0-rc.1), and if the issue persists, comment below so we can discuss it.

Thanks!

Unless I'm reading the docs wrong, this is still an issue.

You can just use ngFocus: http://docs.angularjs.org/api/ng.directive:ngFocus

Not sure you really need this.

Yes we do.
Otherwise why would we need $dirty or $valid? We could handle those by some custom directives. But this is not what angular is about.
So I think form.$focused is definitively needed.

+1

+1 This is definitely needed. Consider the situation:

<div class="input-group">
        <input ng-model="formname.fieldname.val" name="fieldname" />

        <span class="input-group-addon">
              <i class="glyphicon glyphicon-time"></i>
        </span>
 </div>

I can do:

input:focus + .input-group-addon .glyphicon { color: $focusColor; }

But I cannot do this if I want the icon-group-addon before the input. $focus flag on form models would solve this.

<div class="input-group">
       <span class="input-group-addon">
              <i class="glyphicon glyphicon-time" 
                 ng-class="{ 'focus': formname.fieldname.$focus }"></i>
        </span>
        <input ng-model="formname.fieldname.val" name="fieldname" />        
 </div>

+1

Consider situation where error "This field does not pass validation" is shown even when input is focus. User would be annoyed seeing the error message as he's intending to enter the right text.

@poonwu

@poonwu, this is what .ng-touched/ng-untouched are for (although not exactly the same as focus).
A focus specific class might indeed be needed in some applications, but we don't want to clutter the core with stuff that may be unused by most. Especially since this is trivial to implement outside of core.

@poonwu

+1
I agree that it would still be useful. Similar to what @poonwu mentions - Many use cases exist where one may want to show validation-specific messages or styles for fields once $touched is true, but only if the field does not have focus. $focused would certainly help.

+1

+1 - this flag can definitely come useful in many cases.

+1

@btford

@btford Any idea on this one? Or is it gone for good? It seems you've had people chiming in on this for almost 5 years now.

Cheers

As explained in #903 (comment), I still believe this is not something that belongs in core. It is not as often needed and is pretty easy to implement as a standalone directive (and even distribute as a 3rd-party module). Especially since Angular (2+) doesn't support it either afaik, I would be very hesitant about adding it to AngularJS (1.x).

+1

+1
Damn, they don't undserstand.

Navigation Menu

Repository navigation

add $hasFocus or $focused to forms #903

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

add $hasFocus or $focused to forms #903

Description

Activity

mpaulucci commented on Oct 23, 2012

celmaun commented on Nov 30, 2012

btford commented on Aug 24, 2013

thauber commented on Nov 21, 2013

btford commented on Nov 21, 2013

LukeSkyw commented on Jul 17, 2014

turquoiseowl commented on Oct 8, 2014

Jakobovski commented on Oct 9, 2014

parliament718 commented on Oct 24, 2014

wub commented on Nov 24, 2015

danmoc commented on Mar 3, 2016

tomjwilliamson commented on Mar 11, 2016

poonwu commented on Mar 22, 2016

gkalpak commented on Mar 22, 2016

agscheidle commented on Apr 14, 2016

anmarcek commented on Nov 8, 2016

dmaster7 commented on Dec 27, 2016

camt commented on Mar 20, 2017

johandelforge commented on Mar 26, 2017

wub commented on Mar 26, 2017

gkalpak commented on Mar 27, 2017

SarikaVanapalli commented on Apr 19, 2017

sidhujaspreet commented on Sep 26, 2017

keremkayhan commented on Oct 16, 2017

r0ssIV commented on Feb 27, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions