This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
maxlength issue in 1.3.0 beta 15 (invalid -> valid) #8234
Description
Hi,
I was using beta 11 and everything was fine, upgraded to 15 and got the issue.
I output a complex object with several ng-repeats etc, which eventually boils down to something like:
<input class="form-control" name="questionText" type="text" ng-model="question.text" placeholder="{{ 'ContentEntity_EvaluateTask_ClaimPlaceholder' | i18n }}" maxlength="150" required />
I have CSS classes setup that highlight invalid fields with red. So after upgrade to beta 15 when entire object is rendered I see that input fields become red (my css style for invalid state) for a fraction of a second and then back to "valid" (non red). When I remove the maxlength attribute - no blinking occurs. As I mentioned beta 11 works just fine.
Thank you!
P.S.: using IE11
Activity
Narretz commentedon Jul 17, 2014
Can you please provide a reproduction in a plnkr.co or similar?
snekbaev commentedon Jul 17, 2014
Hi,
sure, here you go: http://plnkr.co/mY219dSGAl1EEngRRavr
open in IE11 and you will see a quick red blink. If you comment out beta.15 script reference and put back beta.5 - no blinking occurs. While using beta.15 script try removing the "maxlength" attribute and you will see that blinking doesn't happen.
Thank you!
caitp commentedon Jul 17, 2014
just tried this on saucelabs and I'm not seeing the issue? (I did modify the plunk to use ng-maxlength rather than maxlength though, because browsers will tend to not allow you to enter more characters than the actual maxlength attribute value).
Narretz commentedon Jul 17, 2014
I checked on IE11, I see the issue, and it's truly confusing.
In the plunker, for the working input, I replaced
maxlengthwithng-maxlengthand then the error appears there, too. However, when I replaceng-maxlengthon the non-working example, nothing changes.Also, the flash appears first in beta.12, which is when the validator refactoring was introduced. I remember there was a bug with ng-maxlength and initial validation, maybe that is related.
It's pretty strange though that only the input in ngRepeat is affected
snekbaev commentedon Jul 17, 2014
Hi @caitp ,
thank you for your reply. I opened that plnkr and saw the blinking. I changed my local version to use ng-maxlength, I still see the blinking, moveover, now I can enter more characters than the limit I've set (though field gets marked as invalid). That's why I was using the maxlength because it was limiting the input.
snekbaev commentedon Jul 17, 2014
@Narretz I jumped from 11 to 15, quickly checked that it was reworked from the sources, but didn't check since which version :) but yeah, apparently you found it too :) I'm staying with beta11 meanwhile, otherwise I have massive red blinking on every tree item selection :)
Thank you!
59 remaining items
fix(ngAnimate): defer DOM operations for changing classes to postDigest
fix(ngAnimate): defer DOM operations for changing classes to postDigest
tbosch commentedon Oct 3, 2014
Assigned to @caitp as she is working on a PR for this
fix(ngAnimate): defer DOM operations for changing classes to postDigest
fix(ngAnimate): defer DOM operations for changing classes to postDigest
fix(ngAnimate): defer DOM operations for changing classes to postDigest
fix(ngAnimate): defer DOM operations for changing classes to postDigest